From 4ea9e83e6793719ca4139309b0cfabd9ebecbbe7 Mon Sep 17 00:00:00 2001
From: Ales Nosek <ales.nosek@gmail.com>
Date: Sun, 31 Jan 2016 10:28:12 -0800
Subject: [PATCH] Make the USER and PASSWORD parameters optional

---
 README.md            |  9 +++++----
 check_galera_cluster | 44 ++++++++++++++++++++------------------------
 2 files changed, 25 insertions(+), 28 deletions(-)
 mode change 100755 => 100644 check_galera_cluster

diff --git a/README.md b/README.md
index adafb54..e5497f4 100644
--- a/README.md
+++ b/README.md
@@ -2,11 +2,12 @@ nagios-plugin-check_galera_cluster
 =======================================
 
 A nagios plugin to check status of a galera cluster
-Version 1.0, Guillaume Coré <g@fridim.org>
+
+    Version 1.1, Guillaume Coré <fridim@onfi.re>, Ales Nosek <ales.nosek@gmail.com>
 
     check_galera_cluster is a Nagios plugin to monitor Galera cluster status.
     
-    check_galera_cluster -u USER -p PASSWORD [-H HOST] [-P PORT] [-w SIZE] [-c SIZE] [-f FLOAT] [-0]
+    check_galera_cluster [-u USER] [-p PASSWORD] [-H HOST] [-P PORT] [-w SIZE] [-c SIZE] [-f FLOAT] [-0]
     
     Options:
       u)
@@ -14,9 +15,9 @@ Version 1.0, Guillaume Coré <g@fridim.org>
       p)
         MySQL password.
       H)
-        MySQL host. Default is localhost.
+        MySQL host.
       P)
-        MySQL port. Default is 3306.
+        MySQL port.
       w)
         Sets minimum number of nodes in the cluster when WARNING is raised. (default is same as critical).
       c)
diff --git a/check_galera_cluster b/check_galera_cluster
old mode 100755
new mode 100644
index 89b5d95..5552165
--- a/check_galera_cluster
+++ b/check_galera_cluster
@@ -1,7 +1,7 @@
 #!/bin/bash
 PROGNAME=`basename $0`
-VERSION="Version 1.0,"
-AUTHOR="Guillaume Coré <g@fridim.org>"
+VERSION="Version 1.1"
+AUTHOR="Guillaume Coré <fridim@onfi.re>, Ales Nosek <ales.nosek@gmail.com>"
 
 ST_OK=0
 ST_WR=1
@@ -17,7 +17,7 @@ print_help() {
   echo ""
   echo "$PROGNAME is a Nagios plugin to monitor Galera cluster status."
   echo ""
-  echo "$PROGNAME -u USER -p PASSWORD [-H HOST] [-P PORT] [-w SIZE] [-c SIZE] [-f FLOAT] [-0]"
+  echo "$PROGNAME [-u USER] [-p PASSWORD] [-H HOST] [-P PORT] [-w SIZE] [-c SIZE] [-f FLOAT] [-0]"
   echo ""
   echo "Options:"
   echo "  u)"
@@ -25,9 +25,9 @@ print_help() {
   echo "  p)"
   echo "    MySQL password."
   echo "  H)"
-  echo "    MySQL host. Default is localhost."
+  echo "    MySQL host."
   echo "  P)"
-  echo "    MySQL port. Default is 3306."
+  echo "    MySQL port."
   echo "  w)"
   echo "    Sets minimum number of nodes in the cluster when WARNING is raised. (default is same as critical)."
   echo "  c)"
@@ -41,8 +41,6 @@ print_help() {
 
 # default values
 crit=2
-port='3306'
-mysqlhost='localhost'
 fcp=0.1
 
 while getopts “hvu:p:H:P:w:c:f:0” OPTION; do
@@ -91,25 +89,23 @@ if [ -z "$warn" ]; then
   warn=$crit
 fi
 
-# MANDATORY args
-if [ -z "$mysqluser" ]; then
-  echo "argument -u missing"
-  print_help
-  exit $ST_UK
-fi
+create_param() {
+  if [ -n "$2" ]; then
+    echo $1$2
+  fi
+}
 
-if [ -z "$password" ]; then
-  echo "argument -p missing"
-  print_help
-  exit $ST_UK
-fi
+param_mysqlhost=$(create_param -h "$mysqlhost")
+param_port=$(create_param -P "$port")
+param_mysqluser=$(create_param -u "$mysqluser")
+param_password=$(create_param -p "$password")
 
-r1=$(mysql -h$mysqlhost -P$port -u$mysqluser -p$password -B -N -e "show status like 'wsrep_cluster_size'"|cut -f 2) # 3  (GALERA_CLUSTER_SIZE)
-r2=$(mysql -h$mysqlhost -P$port -u$mysqluser -p$password -B -N -e "show status like 'wsrep_cluster_status'"|cut -f 2) # Primary
-r3=$(mysql -h$mysqlhost -P$port -u$mysqluser -p$password -B -N -e "show status like 'wsrep_flow_control_paused'"|cut -f 2) # < 0.1
-r4=$(mysql -h$mysqlhost -P$port -u$mysqluser -p$password -B -N -e "show status like 'wsrep_ready'"|cut -f 2)  # ON
-r5=$(mysql -h$mysqlhost -P$port -u$mysqluser -p$password -B -N -e "show status like 'wsrep_connected'"|cut -f 2)  # ON
-r6=$(mysql -h$mysqlhost -P$port -u$mysqluser -p$password -B -N -e "show status like 'wsrep_local_state_comment'"|cut -f 2)  # Synced
+r1=$(mysql $param_mysqlhost $param_port $param_mysqluser $param_password -B -N -e "show status like 'wsrep_cluster_size'"|cut -f 2) # 3  (GALERA_CLUSTER_SIZE)
+r2=$(mysql $param_mysqlhost $param_port $param_mysqluser $param_password -B -N -e "show status like 'wsrep_cluster_status'"|cut -f 2) # Primary
+r3=$(mysql $param_mysqlhost $param_port $param_mysqluser $param_password -B -N -e "show status like 'wsrep_flow_control_paused'"|cut -f 2) # < 0.1
+r4=$(mysql $param_mysqlhost $param_port $param_mysqluser $param_password -B -N -e "show status like 'wsrep_ready'"|cut -f 2)  # ON
+r5=$(mysql $param_mysqlhost $param_port $param_mysqluser $param_password -B -N -e "show status like 'wsrep_connected'"|cut -f 2)  # ON
+r6=$(mysql $param_mysqlhost $param_port $param_mysqluser $param_password -B -N -e "show status like 'wsrep_local_state_comment'"|cut -f 2)  # Synced
 
 if [ -z "$r3" ]; then
   echo "UNKNOWN: wsrep_flow_control_paused is empty"