Michelle/redlight
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 11 Wiki Activity

Improve email verification error handling in registration and resend verification endpoints
Some checks failed
Build & Push Docker Image / build (push) Has been cancelled
Details

Browse Source
This commit is contained in:
Michelle
2026-02-27 17:21:01 +01:00
parent 4d1245f358
commit 4d6a09c3fd
1 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
server/routes/auth.js
View File

@@ -71,8 +71,13 @@ router.post('/register', async (req, res) => {
try { appName = JSON.parse(brandingSetting.value).appName || appName; } catch {} try { appName = JSON.parse(brandingSetting.value).appName || appName; } catch {}
} }
sendVerificationEmail(email.toLowerCase(), display_name, verifyUrl, appName) try {
.catch(err => console.error('Verification mail failed (non-fatal):', err.message)); await sendVerificationEmail(email.toLowerCase(), display_name, verifyUrl, appName);
} catch (mailErr) {
console.error('Verification mail failed:', mailErr.message);
// Account is created but email failed — user can resend from login page
return res.status(201).json({ needsVerification: true, emailFailed: true, message: 'Account created but verification email could not be sent. Please try resending.' });
}
return res.status(201).json({ needsVerification: true, message: 'Verification email has been sent' }); return res.status(201).json({ needsVerification: true, message: 'Verification email has been sent' });
} }
@@ -164,14 +169,17 @@ router.post('/resend-verification', async (req, res) => {
try { appName = JSON.parse(brandingSetting.value).appName || appName; } catch {} try { appName = JSON.parse(brandingSetting.value).appName || appName; } catch {}
} }
// Fire-and-forget — do not await so SMTP timeouts don't fail the request try {
sendVerificationEmail(email.toLowerCase(), user.display_name || user.name, verifyUrl, appName) await sendVerificationEmail(email.toLowerCase(), user.display_name || user.name, verifyUrl, appName);
.catch(err => console.error('Resend verification mail failed (non-fatal):', err.message)); } catch (mailErr) {
console.error('Resend verification mail failed:', mailErr.message);
return res.status(502).json({ error: 'Email could not be sent. Please check your SMTP configuration.' });
}
res.json({ message: 'If an account exists, a new email has been sent.' }); res.json({ message: 'If an account exists, a new email has been sent.' });
} catch (err) { } catch (err) {
console.error('Resend verification error:', err); console.error('Resend verification error:', err);
res.status(500).json({ error: 'Email could not be sent' }); res.status(500).json({ error: 'Internal server error' });
} }
}); });